Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change --max-worker-restart option to a sensible value #226

Closed
nicoddemus opened this issue Aug 18, 2017 · 2 comments · Fixed by #436
Closed

Change --max-worker-restart option to a sensible value #226

nicoddemus opened this issue Aug 18, 2017 · 2 comments · Fixed by #436

Comments

@nicoddemus
Copy link
Member

The default value allows for infinite restarts, but this is a serious problem for suites which are during collection because the test run never finishes.

We should change the default to a sensible number, @RonnyPfannschmidt suggested 4 times the number of nodes as default. A value of 0 would mean the previous behavior.

@timj
Copy link
Contributor

timj commented Sep 27, 2017

I strongly endorse this. We use C++ python modules and sometimes there is a SEGV and it took us a while to understand why we ended up with locked up machines forking processes until the machine begged for mercy. It's highly unlikely that in our case a restart would ever be the right thing to do.

@blueyed
Copy link
Contributor

blueyed commented Jun 1, 2019

@timj
Care to create a PR for this?

@nicoddemus nicoddemus changed the title Change --max-slave-restart option to a sensible value Change --max-worker-restart option to a sensible value Jun 6, 2019
nicoddemus added a commit to nicoddemus/pytest-xdist that referenced this issue Jun 6, 2019
nicoddemus added a commit to nicoddemus/pytest-xdist that referenced this issue Jun 6, 2019
nicoddemus added a commit to nicoddemus/pytest-xdist that referenced this issue Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants