From 311cbfabfb13ab1980b9330a1572e93d6d20b698 Mon Sep 17 00:00:00 2001 From: Lukas Geiger Date: Sun, 21 Jun 2020 01:00:02 +0200 Subject: [PATCH] Prefer list comprehensions over list.append() --- src/xdist/workermanage.py | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/xdist/workermanage.py b/src/xdist/workermanage.py index 60b95f34..6a47e1c7 100644 --- a/src/xdist/workermanage.py +++ b/src/xdist/workermanage.py @@ -63,10 +63,7 @@ def rsync_roots(self, gateway): def setup_nodes(self, putevent): self.config.hook.pytest_xdist_setupnodes(config=self.config, specs=self.specs) self.trace("setting up nodes") - nodes = [] - for spec in self.specs: - nodes.append(self.setup_node(spec, putevent)) - return nodes + return [self.setup_node(spec, putevent) for spec in self.specs] def setup_node(self, spec, putevent): gw = self.group.makegateway(spec) @@ -158,11 +155,10 @@ class HostRSync(execnet.RSync): def __init__(self, sourcedir, *args, **kwargs): self._synced = {} - self._ignores = [] ignores = kwargs.pop("ignores", None) or [] - for x in ignores: - x = getattr(x, "strpath", x) - self._ignores.append(re.compile(fnmatch.translate(x))) + self._ignores = [ + re.compile(fnmatch.translate(getattr(x, "strpath", x))) for x in ignores + ] super(HostRSync, self).__init__(sourcedir=sourcedir, **kwargs) def filter(self, path):