Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add setuptools python_requires check #103

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

Nicusor97
Copy link
Contributor

Note: supporting python_requires requires setuptools>=24.2.0 and pip>=9.0.0 to benefit from it.
Details here: https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires

Will prevent users with Python 2.7 or 3.5 from downloading a sdist version they cannot build.

I see two problems:

From my point of view, both cases will be fixed by adding python_requires>=3.6 the same as pytest: https://github.com/pytest-dev/pytest/blob/main/setup.cfg#L54

(I'm not sure if the changelog should be updated in the same PR, if yes I will do it in another commit)

@graingert
Copy link
Member

also will need to yank v2.0.0

@Nicusor97
Copy link
Contributor Author

@graingert Yes, the v2.0.0 must be yanked.

@graingert
Copy link
Member

python_requires requires setuptools>=24.2.0 and pip>=9.0.0 to benefit from it.

pytest-timeout ships a wheel so should be fine

@Nicusor97
Copy link
Contributor Author

@graingert Do you know if the issues that I have with the jobs on Python 3.6 and 3.9 were there before my changes ?

setup.py Outdated Show resolved Hide resolved
@graingert
Copy link
Member

graingert commented Oct 11, 2021

@graingert Do you know if the issues that I have with the jobs on Python 3.6 and 3.9 were there before my changes ?

3.6 could be related to coverage v6.0.1

@graingert
Copy link
Member

yep 3.6 failures predate this PR #102 (comment)

I fixed the 3.9 linting error

@Nicusor97
Copy link
Contributor Author

Ah, you are right, Thanks for fixing the py3.9 jobs. 😄

@Nicusor97 Nicusor97 closed this Oct 11, 2021
@Nicusor97 Nicusor97 reopened this Oct 11, 2021
@Nicusor97
Copy link
Contributor Author

I closed it by mistake. When the PR will be approved I think a new version should be released and v2.0.0 yanked

@Nicusor97
Copy link
Contributor Author

We need one more approval from one of the maintainers in order to merge this fix. Can someone take a look and also help with releasing a new version (also don't forget to yank the v2.0.0 version).

@henryiii
Copy link

@RonnyPfannschmidt perhaps?

@RonnyPfannschmidt
Copy link
Member

I can approve, but I don't have any bandwidth for unfamiliar releases until the end of the week

@graingert graingert merged commit 00720d1 into pytest-dev:master Oct 11, 2021
@flub
Copy link
Member

flub commented Oct 11, 2021

if in doubt, always update the changelog in the same PR :)

@flub
Copy link
Member

flub commented Oct 11, 2021

2.0.1 released, 2.0.0 yanked

This is a good time to promote: if someone can do a better job than me maintaining pytest-timeout please do so! all you have to do is ask.

@graingert
Copy link
Member

@flub thanks for the release and the yank!

@graingert
Copy link
Member

if in doubt, always update the changelog in the same PR :)

If every PR includes a changelog change then all PRs will conflict, something like towncrier can help here

@flub
Copy link
Member

flub commented Oct 17, 2021

if in doubt, always update the changelog in the same PR :)

If every PR includes a changelog change then all PRs will conflict, something like towncrier can help here

Yeah, true. But this isn't exactly a super busy project... I'm rather for keeping things simple if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants