Raise an error if mocker is used in a with context
#165
Conversation
|
Thanks a lot @binarymason! 1.11.2 released with this. 👍 |
|
fwiw, the CHANGELOG / release notes say Also, I feel like this should probably catch situations in which multiple context managers are used? with context_manager_1, mocker.patch(...):Thoughts? Might be harder to detect. |
Oh right, I will update the CHANGELOG thanks
I thought about that too, but I couldn't come up with a good way to detect that too. In the end though I think this is fine, this will probably catch 99% of the mistakes. 👍 Thanks again! |
On pytest-dev#165, a change was added to raise an Exception when trying to use `mocker.patch.object` as a context manager, as its behavior is not supported in the plugin. However, the context managers for the remaining patch options (dict, multiple, and normal patch) still work as usual. With this change, we check if we are in a context manager when starting the patch, so all the methods will raise the exception if corresponds
|
Feedback: whilst presumably for a good reason, this did introduce a breaking change for a rarely-built project of ours. |
|
Thanks @liamdawson, can you share more details? This error was introduced because otherwise you would get a criptic message otherwise. |
Ref: #164