fix: upgrade pip before running tox #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeyondEvil
force-pushed
the
jim/update-pip-in-tests
branch
from
1255af2
to
cf3df95
Compare
BeyondEvil
force-pushed
the
jim/update-pip-in-tests
branch
from
a272b3d
to
1fbb624
Compare
This was referenced Jul 15, 2022
Closed
mattip
reviewed
Jul 16, 2022
| # TODO: This test takes 10(!) times as long as the regular py38 on Windows | ||
| # - os: windows-latest | ||
| # name: pypy3-windows | ||
| # python-version: pypy-3.8 |
There was a problem hiding this comment.
wow, that is slow.I wonder if pypy-3.8-nightly is any faster?
There was a problem hiding this comment.
There was a problem hiding this comment.
wow, 16m 26s for pypy3.8 on windows, ~2m for cpython on windows, ~3 min for pypy on ubuntu, ~1 min for cpython on ubuntu.
There was a problem hiding this comment.
I wonder what exactly is happening.
A lot of tests use regex, could that be it?
Anyway, I'm rewriting the plugin, and as an effect of that, I'm also having to re-write a lot of the test.
It will be interesting to see what the difference might be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.