Separate Nightly workflow #488
Conversation
| @@ -0,0 +1,9 @@ | |||
| name: Nightly tests | |||
There was a problem hiding this comment.
Out of curiosity, why separate these workflows?
There was a problem hiding this comment.
Basically for the same reasons we don't put all python code in one file, logical separation, readability, maintainability, etc.
Which, imo, is especially true for CI config which has a tendency to rarely see changes once defined. So having it logically separated (I will separate out publish to it's own file as well) will help when someone has to make changes.
There was a problem hiding this comment.
For a concrete example: https://github.com/pytest-dev/pytest-html/blob/master/.github/workflows/actions.yml#L36
All these if makes at least my head hurt. Can I wrap my head around it? Sure, but it will take some time. And 6 months later when I need to revisit, I'm going to need to go through that pain again.
* remove phantomjs dependency (#424) * properly classify all npm dependencies (#425) * Move the changelog to read the docs (#423) * split plugin.py into smaller files (#427) * Implement the visible URL query parameter to control visibility of test results on page load. (#433) * enable control of test result visability via query params * Allow for redacting of environment table values (#431) * Disable Codecov (#480) * Disable Codecov * Disable pypy3 on mac * Add Tests.yml reusable workflow (#484) * Use the tests reusable workflow (#486) * Migrate to precommit.ci (#487) * Separate Nightly workflow (#488) Co-authored-by: Gleb Nikonorov <gleb.i.nikonorov@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* remove phantomjs dependency (pytest-dev#424) * properly classify all npm dependencies (pytest-dev#425) * Move the changelog to read the docs (pytest-dev#423) * split plugin.py into smaller files (pytest-dev#427) * Implement the visible URL query parameter to control visibility of test results on page load. (pytest-dev#433) * enable control of test result visability via query params * Allow for redacting of environment table values (pytest-dev#431) * Disable Codecov (pytest-dev#480) * Disable Codecov * Disable pypy3 on mac * Add Tests.yml reusable workflow (pytest-dev#484) * Use the tests reusable workflow (pytest-dev#486) * Migrate to precommit.ci (pytest-dev#487) * Separate Nightly workflow (pytest-dev#488) Co-authored-by: Gleb Nikonorov <gleb.i.nikonorov@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
No description provided.