Migrate to precommit.ci #487
Conversation
Yes, that's because the action uses an absolute path to the As far as I can tell, unfortunately, you can't use a relative path. |
* remove phantomjs dependency (#424) * properly classify all npm dependencies (#425) * Move the changelog to read the docs (#423) * split plugin.py into smaller files (#427) * Implement the visible URL query parameter to control visibility of test results on page load. (#433) * enable control of test result visability via query params * Allow for redacting of environment table values (#431) * Disable Codecov (#480) * Disable Codecov * Disable pypy3 on mac * Add Tests.yml reusable workflow (#484) * Use the tests reusable workflow (#486) * Migrate to precommit.ci (#487) * Separate Nightly workflow (#488) Co-authored-by: Gleb Nikonorov <gleb.i.nikonorov@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
@BeyondEvil While I use pre-commit.ci myself almost everywhere, I never rely on it for CI pipelines and I do have separated GHA lint pipeline that runs linting using pre-commit. That is for two reasons:
I mentioned that as it might prove useful. |
|
I see. All valid points. But at this time I feel that if it’s good enough for the main pytest project it’s good enough for us. With limited time, at least I have more pressing issues to deal with. Speaking of, any thoughts on why the windows tests started failing? |
|
FYI, you can now use relative paths. 😅 |
|
Sorry but Windows is the only platform about which I do not care, so I did not look at it. I already wasted almost two weeks making Ansible work under GHA WSL1, ended up with an instant heachache when I see Windows ;) |
|
Yeah, I hear ya. I have a strong urge to remove official support for windows. If it works it works, and I can accept patches. But that’s about it. I don’t own a PC and I have a M1 with no feasible means of running a VM yet. |
|
Not that I expect you do work on it, but I have an M1 too and I installed Windows 11 arm64 edition under Parallels and works quite nice and FAST!. Just do not expect to be able to use podman/docker/wsl inside that VM because M1 does not allow nested-virtualization. In fact I even share my code repository across those systems, so I do not need to clone/sync code when testing under a different platform. I was planning to write a blog post about that, but time.... |
|
Yeah, but parallels isn't free. And I don't have a need for it for work and I don't feel like paying for something w.r.t. unpaid OS work. I'll just wait until the folks at VirtualBox catches up. Still nice, will read that blog-post. |
|
That will not catch-up that time, they announced that there are no plans for arm64 on virtualbox. Also UTM seems might be something you want to investigate as open-source (its a gui on top of qemu) |
|
Yeah, I tried UTM but couldn't get it to work. I might revisit. Yeah, I know what they announced. But unless they want to become irrelevant they'll have to as Apple will move "everything" to ARM. |
* remove phantomjs dependency (pytest-dev#424) * properly classify all npm dependencies (pytest-dev#425) * Move the changelog to read the docs (pytest-dev#423) * split plugin.py into smaller files (pytest-dev#427) * Implement the visible URL query parameter to control visibility of test results on page load. (pytest-dev#433) * enable control of test result visability via query params * Allow for redacting of environment table values (pytest-dev#431) * Disable Codecov (pytest-dev#480) * Disable Codecov * Disable pypy3 on mac * Add Tests.yml reusable workflow (pytest-dev#484) * Use the tests reusable workflow (pytest-dev#486) * Migrate to precommit.ci (pytest-dev#487) * Separate Nightly workflow (pytest-dev#488) Co-authored-by: Gleb Nikonorov <gleb.i.nikonorov@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
No description provided.