Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the visible URL query parameter to control visibility of test results on page load. #433

Merged
merged 4 commits into from Dec 21, 2020

Conversation

gnikonorov
Copy link
Member

Implement a new query parameter, visible, to control visibility of test results on page load.

Note that QUnit makes testing this cumbersome. I tested this locally with all possible combinations and things worked as expected ( as did not passing this argument ). I opened #432 to migrate off QUnit and noted the need for URL parameter tests in the issue.

Closes #399

@gnikonorov gnikonorov added the feature This issue/PR relates to a feature request. label Dec 20, 2020
@gnikonorov gnikonorov self-assigned this Dec 20, 2020
Copy link
Contributor

@BeyondEvil BeyondEvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@gnikonorov gnikonorov merged commit cc80986 into pytest-dev:master Dec 21, 2020
@TheCorp
Copy link

TheCorp commented Dec 21, 2020

Beautiful! Thanks!

BeyondEvil pushed a commit to BeyondEvil/pytest-html that referenced this pull request May 10, 2021
…st results on page load. (pytest-dev#433)

* enable control of test result visability via query params

* fix typos and query parsing

* Add changelog entry

* fix type in changelog
BeyondEvil added a commit that referenced this pull request Jan 26, 2022
* remove phantomjs dependency (#424)

* properly classify all npm dependencies (#425)

* Move the changelog to read the docs (#423)

* split plugin.py into smaller files (#427)

* Implement the visible URL query parameter to control visibility of test results on page load. (#433)

* enable control of test result visability via query params

* Allow for redacting of environment table values (#431)

* Disable Codecov (#480)

* Disable Codecov

* Disable pypy3 on mac

* Add Tests.yml reusable workflow (#484)

* Use the tests reusable workflow (#486)

* Migrate to precommit.ci (#487)

* Separate Nightly workflow (#488)

Co-authored-by: Gleb Nikonorov <gleb.i.nikonorov@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
BeyondEvil pushed a commit to BeyondEvil/pytest-html that referenced this pull request Apr 3, 2023
…st results on page load. (pytest-dev#433)

* enable control of test result visability via query params

* fix typos and query parsing

* Add changelog entry

* fix type in changelog
BeyondEvil added a commit to BeyondEvil/pytest-html that referenced this pull request Apr 3, 2023
* remove phantomjs dependency (pytest-dev#424)

* properly classify all npm dependencies (pytest-dev#425)

* Move the changelog to read the docs (pytest-dev#423)

* split plugin.py into smaller files (pytest-dev#427)

* Implement the visible URL query parameter to control visibility of test results on page load. (pytest-dev#433)

* enable control of test result visability via query params

* Allow for redacting of environment table values (pytest-dev#431)

* Disable Codecov (pytest-dev#480)

* Disable Codecov

* Disable pypy3 on mac

* Add Tests.yml reusable workflow (pytest-dev#484)

* Use the tests reusable workflow (pytest-dev#486)

* Migrate to precommit.ci (pytest-dev#487)

* Separate Nightly workflow (pytest-dev#488)

Co-authored-by: Gleb Nikonorov <gleb.i.nikonorov@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control visibility of test results sections by query param
3 participants