Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the report tab title reflect the report name #420

Merged
merged 2 commits into from Dec 13, 2020
Merged

Make the report tab title reflect the report name #420

merged 2 commits into from Dec 13, 2020

Conversation

gnikonorov
Copy link
Member

Make the report tab title the same as the report name in the body for consistency.

Closes #412

@gnikonorov gnikonorov added the bug This issue/PR relates to a bug. label Dec 13, 2020
@gnikonorov gnikonorov self-assigned this Dec 13, 2020
@gnikonorov gnikonorov added feature This issue/PR relates to a feature request. and removed bug This issue/PR relates to a bug. labels Dec 13, 2020
BeyondEvil
BeyondEvil requested changes Dec 13, 2020
View reviewed changes
Copy link
Contributor

@BeyondEvil BeyondEvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Small improvement suggested on tests.

testing/test_pytest_html.py Outdated Show resolved Hide resolved
testing/test_pytest_html.py Outdated Show resolved Hide resolved
testing/test_pytest_html.py Outdated Show resolved Hide resolved
testing/test_pytest_html.py Outdated Show resolved Hide resolved
@BeyondEvil BeyondEvil self-requested a review December 13, 2020 22:05
@gnikonorov
Copy link
Member Author

Looking good! Small improvement suggested on tests.

Sure! Implemented similar to suggested @BeyondEvil

BeyondEvil
BeyondEvil approved these changes Dec 13, 2020
View reviewed changes
Copy link
Contributor

@BeyondEvil BeyondEvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send it! 🚀

@gnikonorov gnikonorov merged commit e260972 into pytest-dev:master Dec 13, 2020
@BeyondEvil BeyondEvil mentioned this pull request Apr 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeyondEvil BeyondEvil BeyondEvil approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea

Assignees

@gnikonorov gnikonorov

Labels
feature This issue/PR relates to a feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report title should reflect in report tab name
2 participants
@gnikonorov @BeyondEvil