Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warnings summary not reflected in html-summary (feature request) #163

Open
nicain opened this issue May 10, 2018 · 10 comments
Open

warnings summary not reflected in html-summary (feature request) #163

nicain opened this issue May 10, 2018 · 10 comments
Assignees
Labels
enhancement This issue/PR relates to a feature request.

Comments

@nicain
Copy link

nicain commented May 10, 2018

In addition to test failure, pytest captures a warnings summary and reports this at the end of the test summary. It would be great if this could be reflected in the html summary as well.

@davehunt davehunt added enhancement This issue/PR relates to a feature request. help wanted labels May 10, 2018
@gnikonorov
Copy link
Member

Hi @davehunt, is this still something that is relevant? If so I'd like to take a stab at implementing it

@BeyondEvil
Copy link
Contributor

Sure, feel free to submit a PR! 👍 @gnikonorov

@gnikonorov
Copy link
Member

Thank you @BeyondEvil!

@gnikonorov
Copy link
Member

Still planning on working on this.
I can start once pytest-dev/pytest#7255 is merged

@nepumuk123
Copy link

Hey @gnikonorov this feature would be great. Are you still planning to do this?

@gnikonorov
Copy link
Member

Hi @nepumuk123, I am yes. We just need to wait for a version of pytest that contains pytest-dev/pytest#7255 to be released. That should be coming soon. I'll update this issue when it happens

@nepumuk123
Copy link

Cool, thank you.

@BeyondEvil
Copy link
Contributor

I think this is merged and released now @gnikonorov :)

@gnikonorov gnikonorov self-assigned this Dec 20, 2020
@gnikonorov
Copy link
Member

I'm going to pick this up again, @BeyondEvil

The solution would involve making a separate 'warnings summary' table similar to the results table but with only 1 data point, the warnings for a test. It would only show tests that emit warnings and would be hidden from view if there are no warnings.

This would involve a merge into your next-gen branch. Do you have any opposition?

@BeyondEvil
Copy link
Contributor

This would involve a merge into your next-gen branch. Do you have any opposition?

I have no idea what the implications will be, but we'll worry about that later. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue/PR relates to a feature request.
Projects
None yet
Development

No branches or pull requests

5 participants