Make Django assertions available outside of a TestCase class

[wgordon17]

No description provided.

[wgordon17]

This is my attempt at addressing some of the concerns in #232.

[blueyed]

This is looking good from a quick glance - thanks for picking it up.

[graingert]

Or replace sys.modules[__name__]

…

On Sun, 16 Jun 2019, 10:43 Pascal Chambon, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pytest_django/asserts.py <#709 (comment)> : > + getattr(test_case, name)(*args, **kwargs) + + return assertion_func + + +__all__ = [] +asserts = set() +asserts.update( + set(attr for attr in vars(TestCase) if attr.startswith('assert')), + set(attr for attr in vars(SimpleTestCase) if attr.startswith('assert')), + set(attr for attr in vars(LiveServerTestCase) if attr.startswith('assert')), + set(attr for attr in vars(TransactionTestCase) if attr.startswith('assert')), +) + +for assert_func in asserts: + locals()[assert_func] = _wrapper(assert_func) locals() is not meant to be always settable, maybe juste use globals() to make it clearer for newcomers? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#709?email_source=notifications&email_token=AADFATAOVYCMNRI6QL2HNKLP2YDNLA5CNFSM4G44C6M2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3VB3AI#pullrequestreview-250224001>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADFATDVJNANXY3Y5OJKR6LP2YDNLANCNFSM4G44C6MQ> .

[pakal]

Approach looks straightforward and handy, thanks for this PR :)

[wgordon17]

@blueyed Any thoughts on when you'd want to merge this?

[blueyed]

Thanks for the update, I've pushed two improvements (better docs (star imports are discouraged), and changed it to use functools.wraps (for doc etc)).

[Mogost]

It looks so simple but so necessary. I look forward to the merge of this PR.

[wgordon17]

@blueyed Thanks so much for those improvements! 🙏

[blueyed]

Thanks! :)

[blueyed]

Released in 3.8.0.. 🎉

[premchalmeti]

@wgordon17 Any reason for not including unittest.TestCase asserts?

[wgordon17]

@premchalmeti, since this repo focuses on Django, it made more sense to focus only on the Django asserts. Additionally, most (if not all) the unittest.TestCase asserts are something that should be more appropriately handled by traditional assert statements, as is the pytest philosophy.