Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage wrongly calculated #596

Open
t-pohl opened this issue Jun 9, 2023 · 0 comments
Open

Coverage wrongly calculated #596

t-pohl opened this issue Jun 9, 2023 · 0 comments

Comments

@t-pohl
Copy link

t-pohl commented Jun 9, 2023

Summary

When using pytest --cov together with a FastAPI app, sqlalchemy (async Postgres connection) and pytest-docker (for the DB) we get back wrongly calculated coverage for the services. For organization purposes we separate our functionality into routers and services where the routers import and use the services.

Expected vs actual result

While the coverage in our router functions seems to be right the coverage in our service functions is not large enough i.e. some lines which are definitely covered are marked as uncovered.

We already tested the following possible fixes:

  • eager loading of the pytest-cov plugin via -p
  • explicitly setting the coverage sources in the command via --cov=...
  • Having __init__.py in all subdirectories

Reproducer

Versions

Python: 3.11.2
pytest: 7.3.1

Config

pyproject.toml:

[tool.coverage.run]
branch = true
source = ['backend']
omit = [
    '*__init__.py',
    'backend/api/schemas/*',
    'backend/database/*',
    'backend/application.py',
    'backend/settings.py',
]

Code

Repo: https://github.com/t-pohl/pytest-coverage-err

Just clone the repo, run poetry install and then poetry run scripts/coverage.sh and observe the results.

The asset_service.py file should have a higher coverage value. One example would be lines 39-41 which are reported as uncovered but are definitely called in the test test_get_asset_not_found inside the file tests/api/test_03_asset.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant