Relax dependency on typing-extensions #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvetlov
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
LGTM
I have a feeling that the PR doesn't make much value (while definitely doesn't harm).
Typing system involves fast, the fresh typing-extensions version is crucial for adopting such changes.
Say, I have a plan to use ParamSpec + Concatenate once is is fully supported by mypy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only use
typing_extensionsfor theLiteraltype, which is available starting from version3.7.2, so we don't necessarily needtyping_extensions>=4.0