New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setuptools_scm configuration #279
Conversation
Interesting, tests are failed. |
We encountered the same issue in the PR where we integrated |
This shouldn't be necessary. I can't check right now but my immediate guess would be to check pip/setuptools versions. I'll try to get back to this once I can look at it from my laptop. |
Oh, I see what's happening: ERROR: FAIL could not package project - v = InvocationError('/opt/hostedtoolcache/Python/3.7.12/x64/bin/python setup.py sdist --formats=zip --dist-dir /home/runner/work/pytest-asyncio/pytest-asyncio/.tox/dist', 1) Tox invokes |
This fixes an issue that forced us to add setuptools_scm to setup.cfg, instead of specifying the dependency just once in pyproject.toml. See discussion #279 Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
Thanks @webknjaz, good find! Enabling build isolation did the trick: The dependency on |
@asvetlov I hope you don't mind I took this PR over :) |
It would've been discovered earlier if |
pyproject.toml
should usesetuptools_scm[toml]
dependency.In turn, bare
setuptools_scm
should be dropped fromsetup.cfg
setup_requires
section.@webknjaz suggested the change for another aio-libs project.