Require typing-extensions on py<3.8 only #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typing.Literal is available since Python 3.8. Use it instead of requiring typing-extensions for systems that no longer have Python 3.7.
mgorny
commented
Jan 17, 2022
| @@ -24,7 +25,11 @@ | |||
| ) | |||
|
|
|||
| import pytest | |||
| from typing_extensions import Literal | |||
|
|
|||
| if sys.version_info >= (3, 8): | |||
There was a problem hiding this comment.
I can change this to use sys.hexversion or ImportError approach if you prefer.
Tinche
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typing.Literal is available since Python 3.8. Use it instead of
requiring typing-extensions for systems that no longer have Python 3.7.