Fix auto marking of async hypothesis tests in auto mode #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Hypothesis test. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
==========================================
+ Coverage 92.79% 92.98% +0.18%
==========================================
Files 3 3
Lines 222 228 +6
Branches 32 32
==========================================
+ Hits 206 212 +6
Misses 10 10
Partials 6 6
Continue to review full report at Codecov.
|
Tinche
approved these changes
Jan 13, 2022
asvetlov
approved these changes
Jan 14, 2022
…thout explicit "asyncio" marker when "--asyncio-mode=auto" is set. The option --asyncio-mode=auto marks all async functions with the asyncio mark during the collection phase. However, when pytest collects the Hypothesis test, the @given decorator has already been applied and the Hypothesis test function is no longer a coroutine. This commit extends the "pytest_pycollect_makeitem" hook to mark Hypothesis tests whose function body is a coroutine. Closes pytest-dev#258 Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
seifertm
force-pushed
the
auto-mode-marks-hypothesis-tests
branch
from
bd8f210
to
732c50b
Compare
|
You're right. It's probably a better idea if the tests are decoupled from the project config. I was hoping to avoid the boilerplate that comes with I rewrote the two test cases to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option
--asyncio-mode=automarks all async functions with theasynciomark during the collection phase. However, when pytest collects the Hypothesis test, the@givendecorator has already been applied and the Hypothesis test function is no longer a coroutine.This commit extends the
pytest_pycollect_makeitemhook to mark Hypothesis tests whose function body is a coroutine.Closes #258
I was uncertain whether to add the tests to the auto mode tests or to the Hypothesis tests. I eventually decided to add them to the tests for the Hypothesis integration. Rather than using
pytesterI added some assertions so the tests would fail in case we ever changeasyncio_modeto something other than auto. Let me know what you think of this.