New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for EOL Python 3.4 #226
Conversation
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
- Coverage 82.06% 81.96% -0.11%
==========================================
Files 55 55
Lines 10161 10161
Branches 1141 1141
==========================================
- Hits 8339 8328 -11
- Misses 1558 1569 +11
Partials 264 264 |
Note that there is an unreleased fix for py34, which really should be released before dropping support for py34. |
Sounds reasonable. Is there a schedule for the next release? |
I see py 1.8.1 has now been released with the Python 3.4 fix: Lines 1 to 5 in 1058b29
Ready for merge? |
@hugovk there are some good changes in here (e.g. f07e105), but IMHO there is no need to drop support if it is not really necessary. |
@blueyed Yes, the main benefit is dropping a few slots from the CI. But if the code isn't updated much, that's no as important. However, 3.4 is now failing on AppVeyor so it looks like some dependencies need pinning to maintain support.
Good idea, please see PR #233. |
That could still be done, of course (or reduced). But removing it from install_requires for example is not really necessary (currently). |
For reference: py34 on AppVeyor fails via pytest installing colorama:
|
It is failing there, and we do not want to put effort into supporting it. Ref: pytest-dev#226 (comment)
I've created #235 to remove py34 from AV. |
It is failing there, and we do not want to put effort into supporting it. Ref: #226 (comment)
Rebased to the remove the non-drop changes in #233. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise looks good
Please squash. I'd like to be able doing it here, but cannot... |
Done! |
Also rename--> split out to #233.appveyor.yml
to.appveyor.yml
to hide it with the other dotfiles, and update some links.