Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing: store called hook_impls #240

Open
blueyed opened this issue Nov 14, 2019 · 1 comment
Open

tracing: store called hook_impls #240

blueyed opened this issue Nov 14, 2019 · 1 comment

Comments

@blueyed
Copy link
Contributor

blueyed commented Nov 14, 2019

With tracing I think it would be good to know where the result is coming from (firstresult=True), and/or which hook_impls have been called in general.

But this could also be useful to know in general, so storing it (optionally?) on the _Result seems like a good idea to me.
It should probably not be full references (except for when tracing is enabled, but that's not easy to know when creating the _Result it seems), but only the plugin_name by default.

Related code:

if firstresult: # first result hooks return a single value
outcome = _Result(results[0] if results else None, excinfo)
else:
outcome = _Result(results, excinfo)

@wahuneke
Copy link
Contributor

Is this a dupe of #235 ? Commenting here in order to create a link between the issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants