Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_shapefile #202

Closed
CwhGIS opened this issue Jul 24, 2023 · 6 comments
Closed

write_shapefile #202

CwhGIS opened this issue Jul 24, 2023 · 6 comments
Labels

Comments

@CwhGIS
Copy link
Contributor

CwhGIS commented Jul 24, 2023

In Swmmio version 0.6.7, there is an issue with the created polygon shapefile not loading correctly in ArcGIS. The extents of the polygons are being ignored. I discovered the problem while referring to this link (https://swmmio.readthedocs.io/en/v0.6.7/_modules/swmmio/utils/spatial.html#write_shapefile), where it seems that you forgot to add the geometry for polygon.
if geomtype== 'polygon': w.poly([row.coords]).
As shown in the provided image, a fixed version is needed.
image

@CwhGIS
Copy link
Contributor Author

CwhGIS commented Sep 22, 2023

What's wrong with this guy? Already two months with no replies?

@bemcdonnell
Copy link
Member

@chuwenhao123 this is an open source software project run by awesome passionate volunteers. You can be a volunteer and help the team if you’d like - the bug fix would be done much faster with you help. Can you help the project? :-)

@CwhGIS
Copy link
Contributor Author

CwhGIS commented Sep 25, 2023

@bemcdonnell Hi, I have already created a pull request. Hope it can be helpful.

@CwhGIS
Copy link
Contributor Author

CwhGIS commented Sep 26, 2023

Hello @bemcdonnell, I noticed an error while merging the files. The specific error message is as follows: "AttributeError: 'ImageDraw' object has no attribute 'textsize'." It appears that this issue is related to Pillow version 10.0, as the ImageDraw.textsize function has been deprecated.

You may want to consider downgrading the version of Pillow to resolve this problem. You can do this by specifying the desired version in your project's dependencies.

Here is the error message for reference:
image

Additionally, there is an open issue on the Pillow GitHub repository related to this problem, which you can track here. I hope this helps you address the issue.

@bemcdonnell
Copy link
Member

@aerispaha @karosc how would you like this handled ?

@aerispaha
Copy link
Member

Hey @chuwenhao123 and others, can we close this issue since we've merged #205?

@CwhGIS CwhGIS closed this as completed Sep 30, 2023
@aerispaha aerispaha added the bug label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants