New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix memory leak in CRS.list_authority #1178
BUG: Fix memory leak in CRS.list_authority #1178
Conversation
2be4e1d
to
fd1c090
Compare
fd1c090
to
c4b9ea2
Compare
Thanks @skogler 👍 |
Happy to help, thanks for the free software :) |
@snowman2 I searched for other usages of What do you think about that one? It seems to me that https://github.com/pyproj4/pyproj/blob/main/pyproj/_transformer.pyx#L116 should probably call |
I believe that should be fine. The |
Ah, I see, because Base is doing, it, you are right! |
Mind rebasing from main? I added a fix (#1179) that should allow the CICD tests to run to completion now. |
List elements were not properly disposed of when iterating the results of proj_identify. This fixes this and simplifies the cleanup logic.
c4b9ea2
to
01b793b
Compare
Sure, done. |
Codecov Report
@@ Coverage Diff @@
## main #1178 +/- ##
=======================================
Coverage 96.19% 96.19%
=======================================
Files 18 18
Lines 1707 1707
=======================================
Hits 1642 1642
Misses 65 65 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thanks @skogler 👍 |
List elements were not properly disposed of when iterating the results of proj_identify. This fixes this and simplifies the cleanup logic.
history.rst
for all changes andapi/*.rst
for new APIYou can reproduce this issue with the following snippet (look at the memory usage):