Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: use regex to process PROJ strings in CRS.to_dict() #1086

Merged
merged 1 commit into from Jun 5, 2022

Conversation

snowman2
Copy link
Member

@snowman2 snowman2 commented Jun 5, 2022

pyproj/crs/crs.py:595:17: C417 Unnecessary use of map - use a generator expression instead.
Related: adamchainz/flake8-comprehensions#409

Based on: rasterio/rasterio#2352 (thanks @groutr 👍)

@snowman2 snowman2 added this to In progress in 3.4.0 Release via automation Jun 5, 2022
@snowman2 snowman2 force-pushed the comprehension branch 2 times, most recently from 40cff8d to 494bc38 Compare June 5, 2022 02:13
@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

Merging #1086 (494bc38) into main (21ccfc3) will increase coverage by 0.00%.
The diff coverage is 90.00%.

❗ Current head 494bc38 differs from pull request most recent head 490b614. Consider uploading reports for the commit 490b614 to get more accurate results

@@           Coverage Diff           @@
##             main    #1086   +/-   ##
=======================================
  Coverage   96.13%   96.14%           
=======================================
  Files          20       20           
  Lines        1785     1789    +4     
=======================================
+ Hits         1716     1720    +4     
  Misses         69       69           
Impacted Files Coverage Δ
pyproj/crs/crs.py 98.04% <90.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3813abb...490b614. Read the comment docs.

@snowman2 snowman2 changed the title REF: use dict comprehension instead of map to process PROJ strings REF: use regex to process PROJ strings in CRS.to_dict() Jun 5, 2022
@snowman2 snowman2 merged commit 9d0a3b1 into pyproj4:main Jun 5, 2022
3.4.0 Release automation moved this from In progress to Done Jun 5, 2022
@snowman2 snowman2 deleted the comprehension branch June 5, 2022 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant