Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use grouped version updates for Dependabot #15920

Merged
merged 4 commits into from
May 8, 2024
Merged

Use grouped version updates for Dependabot #15920

merged 4 commits into from
May 8, 2024

Conversation

shenxianpeng
Copy link
Contributor

@shenxianpeng shenxianpeng commented May 7, 2024 •
edited

Closes #15909

I created the test-groups-updates repo for testing. Based on my test, set patterns to - "*" can create a separate pull request for the remaining python packages.

@shenxianpeng shenxianpeng requested a review from a team as a code owner May 7, 2024 16:48
@shenxianpeng shenxianpeng marked this pull request as draft May 7, 2024 16:58
@shenxianpeng
Copy link
Contributor Author

shenxianpeng commented May 8, 2024 •
edited

open-pull-requests-limit: 99 doesn't need to be that big anymore, the default is 5 but it should not be enough when other package-ecosystem may need to bump, 10 would be enough, I can change it together if need to.

@shenxianpeng shenxianpeng marked this pull request as ready for review May 8, 2024 03:23
@shenxianpeng
Copy link
Contributor Author

Hi @miketheman, this PR is ready for review.

miketheman
miketheman approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's see how this goes.

@miketheman miketheman enabled auto-merge (squash) May 8, 2024 11:17
@miketheman miketheman added developer experience Anything that improves the experience for Warehouse devs dependencies Pull requests that update a dependency file labels May 8, 2024
@miketheman miketheman merged commit 8c51e0a into pypi:main May 8, 2024
17 checks passed
@shenxianpeng shenxianpeng deleted the use-groups-update branch May 8, 2024 12:45
@shenxianpeng
Copy link
Contributor Author

Thanks! to see results early, a manual trigger dependabot may needed.

@miketheman
Copy link
Member

I tried triggering a single update to rebase, but that doesn't appear to have the desired effect. We can wait a full day cycle for it to trigger on its own - no rush.

@shenxianpeng
Copy link
Contributor Author

I see that the dependency PRs seem to be executed, sorry they are not merged in groups as expected.

can you see if there are dependencies running jobs, or just manual triggers again by clicking "Check for updates" for pypi/warehouse ? (Insights -> Dependency graph -> Dependabot)

image

@shenxianpeng
Copy link
Contributor Author

I will try to test again using my fork repo of warehouse.

@miketheman
Copy link
Member

I've reopened the original issue, to continue conversation there, since we can't reopen a Pull Request.

miketheman added a commit that referenced this pull request May 10, 2024
@miketheman
Revert "Use grouped version updates for Dependabot (#15920)"
a63bdba 
This reverts commit 8c51e0a.
miketheman added a commit that referenced this pull request May 10, 2024
@miketheman
Revert "Use grouped version updates for Dependabot (#15920)" (#15932)
20d0a8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miketheman miketheman miketheman approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file developer experience Anything that improves the experience for Warehouse devs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use grouped version updates for Dependabot
2 participants
@shenxianpeng @miketheman