Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all IP Addresses in tests to use RFC-5735 TEST-NET-* addresses. #13186

Open
ewdurbin opened this issue Mar 10, 2023 · 0 comments · May be fixed by #15470
Open

Update all IP Addresses in tests to use RFC-5735 TEST-NET-* addresses. #13186

ewdurbin opened this issue Mar 10, 2023 · 0 comments · May be fixed by #15470
Labels
good first issue This issue is ideal for first-time contributors! testing Test infrastructure and individual tests

Comments

@ewdurbin
Copy link
Member

nitpick: ‏super nitpicky, and not the first violation of this type in the codebase, but per RFC-5735 we ought to use addresses in TEST-NET-* ranges. Thankfully we have pytest-socket (#humbebrag) to prevent actual network calls, so it's not an issue, but I wanted to note it while it was fresh in my head. (Also see https://www.rfc-editor.org/rfc/rfc6890#section-2.2.2)
Might be worth a full sweep cleanup as a separate PR.

Originally posted by @miketheman in #13164 (comment)
@ewdurbin ewdurbin added good first issue This issue is ideal for first-time contributors! testing Test infrastructure and individual tests labels Mar 10, 2023
@ewdurbin ewdurbin mentioned this issue Mar 10, 2023
Merged
@Mr-Sunglasses Mr-Sunglasses linked a pull request Feb 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue This issue is ideal for first-time contributors! testing Test infrastructure and individual tests
Projects
None yet
Milestone
No milestone
1 participant
@ewdurbin