Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please revert changes that lead downstream projects to add extra spaces #453

Open
glensc opened this issue Nov 30, 2022 · 3 comments
Open

Comments

@glensc
Copy link

glensc commented Nov 30, 2022

downstream projects like pipenv are now forced to feed extra spaces:

-charset-normalizer==2.1.1; python_full_version >= '3.6.0'
+charset-normalizer==2.1.1 ; python_full_version >= '3.6.0'

refs:

@ptmcg
Copy link
Member

ptmcg commented Dec 22, 2022

I will do my best, but I need more to work with. Where is the parser that parses these strings? Which version of pyparsing caused this regression? If you could supply a minimal reproducible example, I'll be happy to add it to pyparsing's test suite.

@glensc
Copy link
Author

glensc commented Dec 22, 2022

the full reproducer:

  1. install pipenv
  2. run pipenv install charset-normalizer
  3. run pipenv requirements

look at the output

I'm a high-level user, I know nothing about what is the track from pipenv to pyparsing.

@glensc
Copy link
Author

glensc commented Dec 22, 2022

actually, that doesn't create the markers, I don't know what triggers the creation of the markers like python_full_version >= '3.6.0'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants