Review request: Switching to Group in some pyparsing code

[aucampia]

Hi, I'm not that knowledgeable with pyparsing and would like a second opinion on this PR which replaces some custom class with Group

• Replace ParamList with Group RDFLib/rdflib#2142

If anyone could take a brief look I would appreciate it.

[ptmcg]

I assume you are using the latest version of pyparsing (3.0.9)?

[aucampia]

We have no specific fixed version, we use the latest in CI, and I think we somewhat encourage our users to do the same. Everything worked fine with pyparsing<3.0 though.

[ptmcg]

After cloning the repo, I added this to the bottom of parser.py:

if __name__ == '__main__':
    import pyparsing as pp

    pp.autoname_elements()
    QueryUnit.create_diagram("rdflib_query_unit.html")

which generated this diagram:

rdflib_query_unit.pdf

Maybe this will give some insights into your parser.

[aucampia]

Thanks @ptmcg I will have a look at this