Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirement ranges incompatibility with vendored packaging v23.0 #520

Closed
DavidTProto opened this issue Mar 16, 2023 · 3 comments
Closed

Comments

@DavidTProto
Copy link

As part of your release notes: Updated vendored packaging to 23.0. Forgive me if I'm wrong, but I think there's a change contained in this version: pypa/packaging#624 (_parser.py L142-146).

When you try to build using this new version using wheel==0.40.0 using python setup.py sdist bdist_wheel, you will get an error if your requirements.txt / setup.cfg has the package range syntax (I.e. pandas>=1.3.0,<1.5.*).

The error you will get is:

wheel.vendored.packaging.requirements.InvalidRequirement: Expected end or semicolon (after version specifier)
pandas<1.5.*,>=1.3.0

@agronholm
Copy link
Contributor

Can you point to a repository where this is happening?

@henryiii
Copy link
Contributor

henryiii commented Mar 16, 2023

FYI, that's an invalid specifier set, it should be pandas<1.5,>=1.3.0. The change in that PR was just to improve the error message, it will now say ".* suffix can only be used with == or != operators" (but that PR is not in 23.0, only an upcoming release).

@agronholm
Copy link
Contributor

Yeah, it did look a bit suspicious to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants