Allow METADATA file to contain UTF-8 chars
#489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 68.28% // Head: 68.35% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
==========================================
+ Coverage 68.28% 68.35% +0.06%
==========================================
Files 12 12
Lines 927 929 +2
==========================================
+ Hits 633 635 +2
Misses 294 294
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Please let me know if you think there is a different root cause for the problem and if it should be tackled elsewhere. |
|
I think this is good enough to fix the issue. Thanks! |
agronholm
added a commit
that referenced
this pull request
Nov 9, 2022
|
This is great! When we first wrote this EmailPolicy wasn't available in all our target Pythons. |
agronholm
added a commit
that referenced
this pull request
Nov 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setuptoolsproduces UTF-8PKG-INFOfiles. However, after processed bywheel, some serialization problems show up in theMETADATAfile (see pypa/setuptools#3663 (comment))This PR attempts to allow UTF-8 in
METADATA1 produced by wheel.Closes #488.
Footnotes
Initially, I was not 100% sure if the issue was related to standardization. PyPA specs do mention a bunch of old RFCs, but they are also clear state that "strings must be serialised using the UTF-8 encoding". Flit adopts the UTF-8 approach. ↩