Don't use default macos/arm64 deployment target in calculating the platform tag for fat binaries #390
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atform tag for fat binaries The system compiler in Xcode 12 will not set the deployment target for arm64 below 11.0.0 (which is the first version of macOS supporting arm64). To allow building wheels that target an earlier version of macOS (by way of the x86_64 part of fat binaries) ignore the deployment target in the arm64 part of fat binaries when that's 11.0.0.
|
With this PR it is possible to create wheels targeting the "universal2" installer on Python.org (introduced for Python 3.9.1, and likely the only installer variant for 3.10). The PR should not allow creating wheels that won't work on the macOS version specified in the platform tag: The version in the tag can be lower than 11.0.0, but only when the arm64 part of the binary works on macOS 11.0.0 which is the lowest version of macOS that supports arm64. |
|
Thanks! |
|
Thanks for the quick response. Can you give an indication when this will end up in a release? |
|
I expect to make a new release today or tomorrow. |
agronholm
added a commit
that referenced
this pull request
Dec 13, 2020
7 tasks
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The system compiler in Xcode 12 will not set the deployment target for arm64 below 11.0.0
(which is the first version of macOS supporting arm64). To allow building wheels that target
an earlier version of macOS (by way of the x86_64 part of fat binaries) ignore the deployment
target in the arm64 part of fat binaries when that's 11.0.0.
This fixes #387