Ignores missing DLLs dir in CPython3Windows #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
It breaks cpython3 tests, because they try to access non-existent DLLs dir, that were not mocked.
This dir can be missing in some Python distributions, e.g. in the embeddable Python for Windows. This fix prevents the error described in pypa#2368 Also fixes tests that were broken by prev commit.
gaborbernat
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this way is right, but I did it easier to avoid additional checks. I expect that we will eventually go in the right direction and the system tell us that some file or path is missing. It will happen at runtime on the host or in virtual environment, but not at venv creation time.