Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cast type from Path to text #2288

Merged
merged 6 commits into from Feb 5, 2022
Merged

fix: cast type from Path to text #2288

merged 6 commits into from Feb 5, 2022

Conversation

isac322
Copy link
Contributor

@isac322 isac322 commented Jan 19, 2022

Thanks for contributing, make sure you address all the checklists (for details on how see

development documentation)!

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

Fixes #2282

Type of exe, bak_dir are both PosixPath and subprocess.check_call does not parse it to string when execute given command.

@gaborbernat
PR Feedback
f13477d 
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
@gaborbernat gaborbernat merged commit f969a91 into pypa:main Feb 5, 2022
@isac322 isac322 deleted the fix_mac_m1 branch February 5, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

M1 Mac codesigning issue: execv() arg 2 must contain only strings
2 participants
@isac322 @gaborbernat