Remove unnecessary special cases for bash/zsh #2086
Merged
+8
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal shell utility hash is standard posix. There is no need to special-case it only for bash and zsh. In fact, this check can break the script on shells such as the built-in sh on BSD systems, ksh, ash or busybox sh which are otherwise perfectly capable of running it. The script is a valid posix shell script, as verified by shellcheck. The one feature that depends on bash (checking that the script is sourced rather than executed) will work only on bash, but it is only a safety check. https://pubs.opengroup.org/onlinepubs/9699919799/utilities/hash.html
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #2086 +/- ##
==========================================
- Coverage 93.70% 93.68% -0.03%
==========================================
Files 88 88
Lines 4383 4383
==========================================
- Hits 4107 4106 -1
- Misses 276 277 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gaborbernat
approved these changes
Mar 31, 2021
gaborbernat
requested changes
Mar 31, 2021
|
Released via https://pypi.org/project/virtualenv/20.4.4/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal shell utility hash is standard posix. There is no need to special-case it only for bash and zsh.
In fact, this check can break the script on shells such as the built-in sh on BSD systems, ksh, ash or
busybox sh which are otherwise perfectly capable of running it. The script is a valid posix shell script, as
verified by shellcheck. The one feature that depends on bash (checking that the script is sourced rather
than executed) will work only on bash, but it is only a safety check.
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/hash.html