Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove high constraint for importlib-metadata #2020

Merged
merged 1 commit into from Nov 23, 2020
Merged

Remove high constraint for importlib-metadata #2020

merged 1 commit into from Nov 23, 2020

Conversation

abtreece
Copy link
Contributor

Github issue #2019

Thanks for contributing, make sure you address all the checklists (for details on how see

development documentation)!

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@codecov
Copy link

codecov bot commented Nov 23, 2020 •
edited

Codecov Report

Merging #2020 (820e8b1) into main (6fab6a8) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2020      +/-   ##
==========================================
- Coverage   94.36%   94.25%   -0.12%     
==========================================
  Files          87       87              
  Lines        4316     4316              
==========================================
- Hits         4073     4068       -5     
- Misses        243      248       +5
Flag Coverage Δ
tests 94.25% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ualenv/create/via_global_ref/builtin/pypy/pypy3.py 94.87% <0.00%> (-5.13%) ⬇️
src/virtualenv/info.py 95.00% <0.00%> (-5.00%) ⬇️
src/virtualenv/util/path/_pathlib/__init__.py 93.93% <0.00%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fab6a8...820e8b1. Read the comment docs.

gaborbernat
gaborbernat approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit 13c5369 into pypa:main Nov 23, 2020
@abtreece abtreece deleted the advance-importlib-metadata-version branch November 23, 2020 15:17
e-carlin added a commit to radiasoft/pykern that referenced this pull request Jun 3, 2021
@e-carlin
Fix #99: Relax high constraint for importlib-metadata
ba9f6b3 
In tox 3.21.0 the high constraint for importlib-metadata was relaxed.
tox-dev/tox#1764

A matching PR was also merged in virtualenv.
pypa/virtualenv#2020

So, we no longer need to have a high constraint which should solve the
conflict (importlib-metadata 4.3.0 was installed but we expected <2).
@e-carlin e-carlin mentioned this pull request Jun 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abtreece @gaborbernat