Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Windows 3.7 methodology and later with venv #1976

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Oct 12, 2020

Resolves #1782

@gaborbernat gaborbernat changed the title Start new windows venv support Align Windows 3.7 methodology and later with venv Oct 12, 2020
@pypa pypa deleted a comment from codecov bot Oct 12, 2020
@pypa pypa deleted a comment from codecov bot Oct 12, 2020
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #1976 into main will increase coverage by 0.31%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1976      +/-   ##
==========================================
+ Coverage   93.93%   94.24%   +0.31%     
==========================================
  Files          86       86              
  Lines        4237     4275      +38     
==========================================
+ Hits         3980     4029      +49     
+ Misses        257      246      -11     
Flag Coverage Δ
#tests 94.24% <90.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/virtualenv/activation/via_template.py 100.00% <ø> (ø)
...virtualenv/seed/embed/via_app_data/via_app_data.py 82.35% <0.00%> (-0.18%) ⬇️
src/virtualenv/run/plugin/creators.py 94.00% <60.00%> (+0.12%) ⬆️
...reate/via_global_ref/builtin/via_global_self_do.py 89.87% <72.41%> (-3.09%) ⬇️
...nv/create/via_global_ref/builtin/cpython/common.py 100.00% <100.00%> (ø)
.../create/via_global_ref/builtin/cpython/cpython3.py 96.82% <100.00%> (+1.17%) ⬆️
...nv/create/via_global_ref/builtin/cpython/mac_os.py 83.97% <100.00%> (+0.08%) ⬆️
...alenv/create/via_global_ref/builtin/pypy/common.py 100.00% <100.00%> (ø)
...rc/virtualenv/create/via_global_ref/builtin/ref.py 93.65% <100.00%> (+1.91%) ⬆️
src/virtualenv/seed/wheels/acquire.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b0bbba...4a77007. Read the comment docs.

Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Windows 3.7/3.8+ venv style
1 participant