Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore python3.4 support (add it back to CI) #1965

Merged
merged 7 commits into from
Oct 4, 2020

Conversation

gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Oct 3, 2020

Resolves #1963

@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #1965 into main will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1965   +/-   ##
=======================================
  Coverage   93.93%   93.94%           
=======================================
  Files          86       86           
  Lines        4239     4246    +7     
=======================================
+ Hits         3982     3989    +7     
  Misses        257      257           
Flag Coverage Δ
#tests 93.94% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...virtualenv/seed/embed/via_app_data/via_app_data.py 82.35% <0.00%> (-0.18%) ⬇️
src/virtualenv/util/path/_pathlib/__init__.py 93.93% <91.66%> (+52.27%) ⬆️
src/virtualenv/seed/wheels/acquire.py 100.00% <100.00%> (ø)
...ualenv/create/via_global_ref/builtin/pypy/pypy2.py 92.20% <0.00%> (-6.50%) ⬇️
...ualenv/create/via_global_ref/builtin/pypy/pypy3.py 94.87% <0.00%> (-5.13%) ⬇️
src/virtualenv/info.py 95.00% <0.00%> (-5.00%) ⬇️
src/virtualenv/seed/embed/base_embed.py 96.22% <0.00%> (-1.89%) ⬇️
src/virtualenv/util/path/_pathlib/via_os_path.py 89.62% <0.00%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adcf327...3e2740b. Read the comment docs.

@gaborbernat gaborbernat changed the title Run test suite with python3.4 Restore python3.4 support (add it back to CI) Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python3.4: Path has no attribute write_bytes
1 participant