diff --git a/docs/changelog/2058.bugfix.rst b/docs/changelog/2058.bugfix.rst new file mode 100644 index 000000000..516eff42d --- /dev/null +++ b/docs/changelog/2058.bugfix.rst @@ -0,0 +1 @@ +Running virtualenv ``--upgrade-embed-wheels`` crashes - by :user:`gaborbernat`. diff --git a/src/virtualenv/seed/wheels/periodic_update.py b/src/virtualenv/seed/wheels/periodic_update.py index 18fcfa330..4725a57a8 100644 --- a/src/virtualenv/seed/wheels/periodic_update.py +++ b/src/virtualenv/seed/wheels/periodic_update.py @@ -9,6 +9,7 @@ import ssl import subprocess import sys +import os from datetime import datetime, timedelta from itertools import groupby from shutil import copy2 @@ -235,6 +236,7 @@ def _run_do_update(app_data, distribution, embed_filename, for_py_version, perio search_dirs=search_dirs, app_data=app_data, to_folder=wheelhouse, + env=os.environ ) if dest is None or (u_log.versions and u_log.versions[0].filename == dest.name): break diff --git a/tests/unit/seed/wheels/test_periodic_update.py b/tests/unit/seed/wheels/test_periodic_update.py index 6d0b66d85..2ea473277 100644 --- a/tests/unit/seed/wheels/test_periodic_update.py +++ b/tests/unit/seed/wheels/test_periodic_update.py @@ -300,7 +300,7 @@ def test_do_update_first(tmp_path, mocker, freezer): ] download_wheels = (Wheel(Path(i[0])) for i in pip_version_remote) - def _download_wheel(distribution, version_spec, for_py_version, search_dirs, app_data, to_folder): + def _download_wheel(distribution, version_spec, for_py_version, search_dirs, app_data, to_folder, env): assert distribution == "pip" assert for_py_version == "3.9" assert [str(i) for i in search_dirs] == [str(extra)] @@ -361,7 +361,7 @@ def test_do_update_skip_already_done(tmp_path, mocker, freezer): extra = tmp_path / "extra" extra.mkdir() - def _download_wheel(distribution, version_spec, for_py_version, search_dirs, app_data, to_folder): # noqa + def _download_wheel(distribution, version_spec, for_py_version, search_dirs, app_data, to_folder, env): # noqa return wheel.path download_wheel = mocker.patch("virtualenv.seed.wheels.acquire.download_wheel", side_effect=_download_wheel)