Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version in published docs title #829

Open
bhrutledge opened this issue Nov 10, 2021 · 5 comments
Open

Fix version in published docs title #829

bhrutledge opened this issue Nov 10, 2021 · 5 comments
Assignees

Comments

@bhrutledge
Copy link
Contributor

bhrutledge commented Nov 10, 2021

After releasing 3.6.0, I noticed that the docs at https://twine.readthedocs.io/ were titled "twine 3.5.1.dev7+g5a793bf documentation". Looks like that's because the default is https://twine.readthedocs.io/en/latest/, while https://twine.readthedocs.io/en/stable/ shows "twine 3.6.0 documentation". I was able to update the latest version by manually triggering a build.

Some thoughts:

@bhrutledge
Copy link
Contributor Author

I changed the default version to stable at https://readthedocs.org/dashboard/twine/advanced/. Leaving this open until the next release, to see what it takes to bump latest to the next dev release.

@bhrutledge bhrutledge self-assigned this Nov 28, 2021
@bhrutledge
Copy link
Contributor Author

After releasing 3.7.0, the stable docs updated as expected, but I had to manually trigger a build of latest. It'd be nice if that could be automated when the tag is pushed.

@sigmavirus24
Copy link
Member

I suspect twine's docs are misconfigured but I'm not added to that project to be able to help diagnose. I suspect latest is still pointing at master instead of main

@bhrutledge
Copy link
Contributor Author

@sigmavirus24 I added you as a maintainer, but it looks like latest is pointing to main.

@sigmavirus24
Copy link
Member

Screenshot-2021-12-01T20:40:17

It looks like it received webhook activity and the last one there shows that it didn't trigger a build for some reason

Screenshot-2021-12-01T20:41:56
https://readthedocs.org/dashboard/twine/integrations/92630/exchange/a446d53b-b81d-401d-af3e-9b984d32a392/ for reference

Of the last 3 shown in that screenshot - the 2 most recent didn't trigger a build but the 3rd most recent did. The 3rd most recent was a push from @bhrutledge. The last two were a create and a push. I suspect the create was the tag creation and then push was the push with the commit/tag in it. Maybe someone at RTD can explain the reason why the exchange above didn't result in a build. Our config looks right to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants