Fix the "safe_name" attribute of PackageFile for backwards compatibility #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
force-pushed
the
issue-743
branch
2 times, most recently
from
e5641cf
to
57a19f3
Compare
|
CC: @bhrutledge @jaraco |
pablogsal
force-pushed
the
issue-743
branch
3 times, most recently
from
0027889
to
92c78cb
Compare
Commit 0bd26af introduced a regression that was causing some namespace packages with dots in them fail to upload to PyPI. The reason is because `packaging.utils.canonicalize_name()` is not equivalent to `pkg_resources.safe_name()` as the former transforms the "." into "-", while the later only does it for non-alphanumeric/. characters. Closes: pypa#743
bhrutledge
reviewed
Mar 16, 2021
Co-authored-by: Brian Rutledge <brian@bhrutledge.com>
jaraco
approved these changes
Mar 16, 2021
It seems so. I would recommend doing the removal in a different change to keep things clean but I can push some commit to remove |
Thanks @pablogsal. I'm going to merge this, then follow up with the removal of |
bhrutledge
added a commit
to bhrutledge/twine
that referenced
this pull request
Mar 17, 2021
bhrutledge
added a commit
to bhrutledge/twine
that referenced
this pull request
Mar 17, 2021
bhrutledge
added a commit
that referenced
this pull request
Mar 17, 2021
This was referenced Mar 17, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 0bd26af introduced a regression
that was causing some namespace packages with dots in them fail to
upload to PyPI. The reason is because
packaging.utils.canonicalize_name()is not equivalent topkg_resources.safe_name()as the former transforms the "." into "-",while the later only does it for non-alphanumeric/. characters.
Closes: #743