Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add strict to check command #715

Merged
merged 5 commits into from Nov 22, 2020
Merged

Add strict to check command #715

merged 5 commits into from Nov 22, 2020

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Nov 16, 2020 •
edited

Fixes #562

Draft for:

  • Documentation updates

@altendky altendky marked this pull request as ready for review November 16, 2020 15:39
@bhrutledge bhrutledge changed the title 561 altendky add strict to check command Add strict to check command Nov 16, 2020
@bhrutledge bhrutledge self-requested a review November 16, 2020 15:48
@bhrutledge bhrutledge added this to In progress in Better `check` via automation Nov 17, 2020
@bhrutledge
Copy link
Contributor

@altendky Thanks for picking this up. I've been collecting ways to improve check in a GitHub project, and I'd like to review this through that lens. Aiming to do that this week, possibly tomorrow.

bhrutledge
bhrutledge approved these changes Nov 22, 2020
View reviewed changes
Copy link
Contributor

@bhrutledge bhrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for adding this. It looks like a good place to start, though if/when we want more options, I think we should take a have more discussion about #659.

docs/index.rst

positional arguments:
dist The distribution files to check, usually dist/*

optional arguments:
-h, --help show this help message and exit
--strict Fail on warnings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs!

tests/test_check.py
@@ -127,6 +127,32 @@ def test_check_no_description(monkeypatch, capsys):
)


def test_strict_fails_on_warnings(monkeypatch, capsys):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of moving this to be near similar tests, instead of at the end of the file.

@bhrutledge bhrutledge merged commit 2f3cf38 into pypa:master Nov 22, 2020
Better `check` automation moved this from In progress to Done Nov 22, 2020
ssbarnea
ssbarnea reviewed Nov 23, 2020
View reviewed changes
Copy link

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I waited for this feature for years.

@altendky altendky deleted the 561-altendky-add_strict_to_check_command branch November 23, 2020 12:50
@bhrutledge bhrutledge added this to the 3.3.0 milestone Nov 23, 2020
@pllim pllim mentioned this pull request Dec 15, 2020
Merged
@pllim
Copy link

pllim commented Dec 15, 2020

Hello. May I know when is 3.3.0 release going to happen to get this feature? Thanks!

@bhrutledge
Copy link
Contributor

@pllim Thanks for the nudge. I'm hoping to finish up #718 within the next week, which should be the last piece of the 3.3.0 milestone.

In the meantime, you can use --strict by using the master branch:

pip install -e git+https://github.com/pypa/twine.git#egg=twine

@pllim pllim mentioned this pull request Dec 16, 2020
Closed
@bhrutledge
Copy link
Contributor

This has been released: https://pypi.org/project/twine/3.3.0/

@pllim pllim mentioned this pull request Dec 24, 2020
Merged
@di di mentioned this pull request Jan 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea left review comments

@sigmavirus24 sigmavirus24 sigmavirus24 approved these changes

@bhrutledge bhrutledge bhrutledge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Better `check`
  
Done
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

Add a way to turn twine check warnings into errors
5 participants
@altendky @bhrutledge @pllim @ssbarnea @sigmavirus24