Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

712 Handle EOFErrror with malformed file #714

Merged
merged 2 commits into from Nov 12, 2020
Merged

712 Handle EOFErrror with malformed file #714

merged 2 commits into from Nov 12, 2020

Conversation

nicholasserra
Copy link
Contributor

Related to pypi/warehouse#8815 and pypi/warehouse#8378

Fixes #712
Handle EOFError when uploading malformed tar.gz file. Uses example tar.gz file from issue.

This is a stab at fixing this issue, although I don't love a couple things here:

  • Catching this error within twine, as this is mainly an issue in the sdist package. Is the catch appropriate here?
  • Adding malformed.tar.gz into version control for the test. Doesn't feel great, but maybe it's fine?

Maybe this is all okay. Let me know if there's better opinions or direction here. Thanks! cc @di

@sigmavirus24 sigmavirus24 merged commit 668f4db into pypa:master Nov 12, 2020
@nicholasserra nicholasserra deleted the 712-eof-package-upload branch November 12, 2020 17:05
@bhrutledge bhrutledge added this to In progress in Helpful errors via automation Nov 22, 2020
@bhrutledge bhrutledge moved this from In progress to Done in Helpful errors Nov 22, 2020
@bhrutledge bhrutledge added this to the 3.3.0 milestone Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Helpful errors
  
Done
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

Twine raises EOFErrror with malformed file
3 participants
@nicholasserra @sigmavirus24 @bhrutledge