Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more Travis jobs to GitHub Actions #709

Merged
merged 3 commits into from Oct 19, 2020

Conversation

bhrutledge
Copy link
Contributor

@bhrutledge bhrutledge commented Oct 18, 2020

Closes #650.

Changes

TODO

  • Update "Required" checks

@bhrutledge
Copy link
Contributor Author

Looks like the Travis check is still "Required", but test/3.9, types, and docs are not. Can one of the @pypa/twine-maintainers fix that (and clear the "Expected" status on "Travis CI")?

@bhrutledge bhrutledge added this to the 3.3.0 milestone Oct 18, 2020
@jaraco
Copy link
Member

jaraco commented Oct 18, 2020

Looks like the Travis check is still "Required", but test/3.9, types, and docs are not. Can one of the @pypa/twine-maintainers fix that (and clear the "Expected" status on "Travis CI")?

I've never configured Travis except through the .yml file and uploading encrypted secrets. If some checks are required and others not, I'm not sure where that's configured.

I scrolled around the Travis and Github settings and don't see anything about configuring which checks are required or not. I also searched the Internet, but didn't find anything relevant. It's possible I don't have access either. Does anyone else know what steps are required?

@bhrutledge
Copy link
Contributor Author

I scrolled around the Travis and Github settings and don't see anything about configuring which checks are required or not. Does anyone else know what steps are required?

@di Any thoughts? Is this possibly at the organization level?

@bhrutledge bhrutledge requested a review from di October 18, 2020 18:46
@di
Copy link
Sponsor Member

di commented Oct 19, 2020

It's configured via the branch protection rules:

image

I've configured test/3.9, types, and docs to be required.

@bhrutledge
Copy link
Contributor Author

Thanks, @di! Travis is still showing up as required on this PR. Assuming you disabled it, I'm going to close and reopen this to see if it's all set.

@bhrutledge bhrutledge closed this Oct 19, 2020
@bhrutledge bhrutledge reopened this Oct 19, 2020
@bhrutledge
Copy link
Contributor Author

Hm. Doesn't look like it.

@di
Copy link
Sponsor Member

di commented Oct 19, 2020

Sorry, I missed that. Done.

@bhrutledge bhrutledge merged commit 099ae0e into pypa:master Oct 19, 2020
@bhrutledge bhrutledge deleted the 650-release-action branch October 19, 2020 17:43
@jaraco
Copy link
Member

jaraco commented Oct 20, 2020

It's configured via the branch protection rules:

Aha! Thanks for that tip.

I see that the default behavior is not to have any rules, so no checks are required. I'll probably not enable this feature on my other repos, just because of the toil it would entail to set up and maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Travis with GitHub Actions
4 participants