Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.9 #708

Merged
merged 4 commits into from Oct 18, 2020
Merged

Add support for Python 3.9 #708

merged 4 commits into from Oct 18, 2020

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 14, 2020

Add to tests, Trove classifiers and docs/contributing.rst.

Omitted from the types test because the lxml dependency isn't yet ready for 3.9.

Copy link
Contributor

@bhrutledge bhrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hugovk! You mentioned updating the trove classifiers, but I don't see setup.cfg in this PR. Can you add that?

@bhrutledge
Copy link
Contributor

Omitted from the types test because the lxml dependency isn't yet ready for 3.9.

I think it'd be helpful to add something like #TODO: Add 3.9 when lxml supports it above types.strategy.matrix.python, along with a link to a relevant issue if you have one.

@hugovk
Copy link
Contributor Author

hugovk commented Oct 14, 2020

Oops, classifier now added!

Here's the actual error:

Collecting mypy
  Downloading mypy-0.790-py3-none-any.whl (2.4 MB)
Collecting lxml
  Downloading lxml-4.5.2.tar.gz (4.5 MB)
    ERROR: Command errored out with exit status 1:
     command: /home/runner/work/twine/twine/.tox/types/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-3mbjm8h6/lxml/setup.py'"'"'; __file__='"'"'/tmp/pip-install-3mbjm8h6/lxml/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-3d1hc8ne
         cwd: /tmp/pip-install-3mbjm8h6/lxml/
    Complete output (3 lines):
    Building lxml version 4.5.2.
    Building without Cython.
    Error: Please make sure the libxml2 and libxslt development packages are installed.

https://github.com/hugovk/twine/runs/1254845165?check_suite_focus=true

https://lxml.de/installation.html confirms that libxml2 and libxslt are needed. But perhaps it's easier to wait for wheels. I opened https://bugs.launchpad.net/lxml/+bug/1899830 to request them, and added it in the TODO.

Edit: lxml/lxml#311 is the PR.

@hugovk
Copy link
Contributor Author

hugovk commented Oct 17, 2020

lxml wheels are now available, added 3.9 typing tests and removed the TODO!

Copy link
Contributor

@bhrutledge bhrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bhrutledge bhrutledge merged commit a7baed4 into pypa:master Oct 18, 2020
@bhrutledge bhrutledge added this to the 3.3.0 milestone Oct 18, 2020
@hugovk hugovk deleted the add-3.9 branch October 18, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants