Logged config location #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhrutledge
requested changes
Jul 19, 2020
bhrutledge
requested changes
Jul 30, 2020
sigmavirus24
reviewed
Aug 3, 2020
bhrutledge
approved these changes
Aug 4, 2020
|
Thanks for your patience on the merge; last time I looked there were some bizarre test failures that I wasn't ready to look into, but now I see things are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #674 on a new branch/PR. I used f-strings to log the config location instead of concatenation to stay consistent as advised by @sigmavirus24.