Prints the packages that will be uploaded when using the --verbose option

[VikramJayanthi17]

As per discussion in #381, twine now prints the names of the packages that it will attempt to upload when the --verbose option is selected. The example output below is from the terminal on my MacOs(Mojave) machine.

This change was suggested by @bhrutledge as a simple first change to the --verbose option using the existing verbose pattern before more comprehensive changes are implemented using the stdlib logging system.

[sigmavirus24]

Please fix your failing tests https://travis-ci.org/github/pypa/twine/builds/695224649 and clean up your commit history on the branch

[bhrutledge]

Thanks for working on this, and providing the screenshot.

I also agree re: a clean commit history. Here are some resources:

• Clean up your commits for a pull request
• How (and why!) to keep your Git commit history clean

[bhrutledge]

Good progress! I left a lot of comments, but I think it's mostly polishing up your work.

[VikramJayanthi17]

I added the changes suggested by @bhrutledge, thanks for the help. I wasn't sure what the appropriate docstring would be for the test_get_file_size function, currently it is """Compare the size of a file to the expected value.""" but I am open to suggestions on what to change it to.

[bhrutledge]

Nice! I think this is functionally complete. I'm nit-picking the tests and code style, since we've spent a lot of time on that recently, and I think there are some useful tools and patterns to keep in mind.

[VikramJayanthi17]

I made the changes requested by @bhrutledge, thanks for the feedback.

[VikramJayanthi17]

Added the changes requested by @bhrutledge : eb70d69

The changes that need to be made regarding signatures are still under discussion and I will add any changes to this PR if needed.

[bhrutledge]

Thanks for making those changes!

[VikramJayanthi17]

As discussed above, I changed the upload function by breaking apart the logic of signing and uploading packages. We now print the signature files of the distributions being uploaded. The print statement happens after the PackageFile instantiating loop and before the uploads are attempted or the skip messages are printed. This means that we are signing packages that may be skipped as mentioned by @bhrutledge.
I believe this location for printing would provide the most information to the user(which distributions and signatures we are attempting to upload) without having other messages(like skips) or errors(while uploading) output at the same time.

[sigmavirus24]

Not ever package will have a signed filename. What happens here if it doesn't have a signature file? What does this print? Folks generating signatures should also know that a .asc file is the signature, what are we hoping to communicate by putting (Signature) at the end?

[VikramJayanthi17]

That makes sense, thanks for the feedback. Would you suggest printing the filename like the other files(without anything to indicate that its a signature)? I will also make this print conditional on upload_settings.sign or if its a pre-signed distribution.

[bhrutledge]

Nice work. Almost there, I think.

[VikramJayanthi17]

I added the changes @bhrutledge requested.

Not ever package will have a signed filename. What happens here if it doesn't have a signature file? What does this print?

Additionally I added a clause to check that the package signature will only be displayed if upload_settings.sign is true or if the distribution is pre-signed to address this issue that @sigmavirus24 pointed out. Thanks for the help.

I also added tests to test _make_package and to check that upload prints signatures if appropriate.

[bhrutledge]

Thanks, @VikramJayanthi17. This looks good to me. @sigmavirus24 How about you?

[sigmavirus24]

Do we need to allocate a list here? Would it be better to create a generator and use that in the for-loop? I don't think that's a blocker, just food for thought for @VikramJayanthi17

[bhrutledge]

@VikramJayanthi17 This was released in 3.2.0. Thanks again for your work on this.