Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate releases with CI #544

Merged
merged 3 commits into from Nov 23, 2019
Merged

Automate releases with CI #544

merged 3 commits into from Nov 23, 2019

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Nov 18, 2019

No description provided.

@jaraco
Copy link
Member Author

jaraco commented Nov 23, 2019

Brian, any objections to this approach?

bhrutledge
bhrutledge approved these changes Nov 23, 2019
View reviewed changes
Copy link
Contributor

@bhrutledge bhrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used Travis for deployment yet, but this makes sense to me, and I'd be happy to see it merged. Just two small suggestions for clarity. I also note that this removes the rc release step; I don't know how important that is.

docs/contributing.rst Outdated Show resolved Hide resolved
docs/contributing.rst Outdated Show resolved Hide resolved
@jaraco @bhrutledge
Tweak wording
8304531 
Co-Authored-By: Brian Rutledge <bhrutledge@gmail.com>
@jaraco jaraco merged commit c8dfaf2 into master Nov 23, 2019
@jaraco jaraco deleted the feature/automated-releases branch November 23, 2019 12:49
@jaraco
Copy link
Member Author

jaraco commented Nov 23, 2019

Thanks Brian.

@jaraco
Copy link
Member Author

jaraco commented Nov 23, 2019

3.1.0 was released successfully with this change.

@bhrutledge bhrutledge mentioned this pull request Jul 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhrutledge bhrutledge bhrutledge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jaraco @bhrutledge