Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-evaluate if typing_extensions is still needed as a vendored dependency for pkg_resources #4324

Open
abravalheri opened this issue Apr 22, 2024 · 1 comment · May be fixed by #4347
Open

Re-evaluate if typing_extensions is still needed as a vendored dependency for pkg_resources #4324

abravalheri opened this issue Apr 22, 2024 · 1 comment · May be fixed by #4347

Comments

@abravalheri
Copy link
Contributor

This (typing_extensions) was not listed. The vendored.txt file says the following:

# required for platformdirs on Python < 3.8
typing_extensions==4.4.0

But now we removed support to Python < 3.8, so I guess we can remove this vendored dependency?

Originally posted by @abravalheri in #4320 (comment)
@Avasam
Copy link
Contributor

Avasam commented Apr 25, 2024

I'd be surprised if we can't just hide whatever usage of typing_extensions behind TYPE_CHECKING checks and from __future__ import annotations.

@Avasam Avasam linked a pull request May 7, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed typing_extensions from vendored dependencies Avasam/setuptools
2 participants
@abravalheri @Avasam