-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update generated validation code using validate_pyproject==0.12.1
#3798
Conversation
Hi @abravalheri! This PR allows stub names in |
Do you want to map your package directory to a different folder? That would require further changes. Do you know if basic |
Yes, we currently have a name = namespace.mod.stubs
[options]
packages =
otherpkg-stubs
namespace.mod.stubs
package_dir =
otherpkg-stubs = namespace/mod/stubs I'm not saying this is the best approach. If we install our package, it will install the package content twice -- once as the stubs of another package, and once as a standalone package in our namespace. Our package is not stub-only -- it provides stubs of another package but also two function wrappers that are needed to perform better type annotation with the other package. These wrappers should be imported by clients and therefore we provide a non-stubs import that allows that. |
No problems. Thank you very much for the example, it should be enough to create a test for it. Sorry, I did not understand that part at first! |
validate_pyproject==0.12
validate_pyproject==0.12.1
21479b0
to
21d138e
Compare
No problem at all! Again I am pleasantly surprised by your quick response. Moreover, I can confirm that this PR solves my issue. Looking forward to the release and thank you so much! |
Probably next week. I try to avoid releases on Friday 😝 |
That is quite sensible 😅 |
Summary of changes
validate_pyproject==0.12.1
intox.ini
Closes #3796
Pull Request Checklist
changelog.d/
.(See documentation for details)