Avoid interfering with auto-discovery when creating temporary directories #3704
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abravalheri
commented
Nov 22, 2022
| @@ -385,7 +385,8 @@ def _build_with_temp_dir(self, setup_command, result_extension, | |||
|
|
|||
| # Build in a temporary directory, then copy to the target. | |||
| os.makedirs(result_directory, exist_ok=True) | |||
| with tempfile.TemporaryDirectory(dir=result_directory) as tmp_dist_dir: | |||
| temp_opts = {"prefix": ".tmp-", "dir": result_directory} | |||
There was a problem hiding this comment.
The temp directory here is created inside result_directory because this is the only place we can assume the current process has OS-level rights to write to the disk...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Closes #3692
Pull Request Checklist
changelog.d/.(See documentation for details)