Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging errors: 'underlying buffer has been detached' (pypa#1631) #3690

Merged
merged 1 commit into from Nov 23, 2022

Conversation

dlaugt
Copy link
Contributor

@dlaugt dlaugt commented Nov 17, 2022

Summary of changes

Those changes fix the issue reported in #1631. From a simple test case, the command bdist_wheel displayed error messages:

Traceback (most recent call last):
  File "C:\dev\Python311\Lib\logging\__init__.py", line 1113, in emit
    stream.write(msg + self.terminator)
ValueError: underlying buffer has been detached

Python 3.7 offers a good alternative to change the encoding of the standard output: io.TextIOWrapper.reconfigure (). This alternative solves the error messages.

Pull Request Checklist

@abravalheri
Copy link
Contributor

Thank you very much @dlaugt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants