Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clib build reproducible by sorting sources #3679

Merged
merged 2 commits into from Nov 23, 2022

Conversation

danigm
Copy link
Contributor

@danigm danigm commented Nov 14, 2022

Summary of changes

Sort sources in build_clib command.

Closes #3678

Pull Request Checklist

  • Changes have tests
  • News fragment added in [changelog.d/].

@abravalheri
Copy link
Contributor

abravalheri commented Nov 14, 2022

Hi @danigm thank you very much for the contribution.

Please note that any changes in the setuptools/_distutils directory need to be proposed in the https://github.com/pypa/distutils repository.

Would you like to propose this change to pypa/distutils?

@danigm
Copy link
Contributor Author

danigm commented Nov 15, 2022

Hi @danigm thank you very much for the contribution.

Please note that any changes in the setuptools/_distutils directory need to be proposed in the https://github.com/pypa/distutils repository.

Would you like to propose this change to pypa/distutils?

Thanks for the info. I've removed that change from the PR, that's not "needed" because the build_libraries method overrides the base class functionality, so it should work as expected just with this change.

@abravalheri
Copy link
Contributor

I think this looks great.

If no one beats me, I can merge the PR next time I am releasing a version.

Co-authored-by: Anderson Bravalheri <andersonbravalheri+github@gmail.com>
@abravalheri abravalheri merged commit d805c53 into pypa:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Reproducible build of clib libraries
2 participants