Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Reproducible build of clib libraries #3678

Closed
1 task done
danigm opened this issue Nov 14, 2022 · 0 comments · Fixed by #3679
Closed
1 task done

[FR] Reproducible build of clib libraries #3678

danigm opened this issue Nov 14, 2022 · 0 comments · Fixed by #3679
Labels
enhancement Needs Triage Issues that need to be evaluated for severity and status.

Comments

@danigm
Copy link
Contributor

danigm commented Nov 14, 2022

What's the problem this feature will solve?

The sources for a library can come in a undetermined order, because of the use of globbing or listdir which returns order on disk which is unsorted.

This could leads to random ordering in sources so the build won't be exactly the same for different environments.

This can be solved for each project that builds the sources list dynamically, so this list is sorted, but it's safer to sort at this level and ensure that any project using this gets the reproducible builds without any modification.

Describe the solution you'd like

The build command for a library will be always the same, independently of the setup.py sources list order.

Alternative Solutions

No response

Additional context

No response

Code of Conduct

  • I agree to follow the PSF Code of Conduct
@danigm danigm added enhancement Needs Triage Issues that need to be evaluated for severity and status. labels Nov 14, 2022
danigm added a commit to danigm/setuptools that referenced this issue Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Needs Triage Issues that need to be evaluated for severity and status.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant